Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 10153008: Manage versioned fields correctly in GlueSerializeTest. (Closed)

Created:
8 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
8 years, 7 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, abarth-chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Manage versioned fields correctly in GlueSerializeTest. I improved GlueSerializeTest to be more version-aware and to check for the newer fields only if the format version is high enough. Previously, the pageScaleFactor expectation did not fail in BackwardsCompatibleTest solely because it was set to the default value of 1. I also noticed the other versioned fields were not tested yet. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M webkit/glue/glue_serialize.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/glue_serialize.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/glue_serialize_unittest.cc View 10 chunks +29 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
lgtm
8 years, 7 months ago (2012-05-09 21:52:36 UTC) #1
abarth-chromium
@aelias: If you don't mind, I'm going to put this in the commit-queue to unblock ...
8 years, 7 months ago (2012-05-09 22:02:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/10153008/1
8 years, 7 months ago (2012-05-09 22:03:47 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-10 00:27:25 UTC) #4
Change committed as 136194

Powered by Google App Engine
This is Rietveld 408576698