Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: lib/unittest/html_config.dart

Issue 10153005: unittest step 3 and 4: remove TestFramework.dart, make test.dart use (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/unittest/dom_config.dart ('k') | lib/unittest/html_enhanced_config.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/unittest/html_config.dart
diff --git a/lib/unittest/html_config.dart b/lib/unittest/html_config.dart
index 5f996a0168404d021c67c5b32cff110ba3cea9e8..627791e7167cc8af6c3bb3c7f8e6ea378bdd355c 100644
--- a/lib/unittest/html_config.dart
+++ b/lib/unittest/html_config.dart
@@ -24,7 +24,7 @@ class HtmlConfiguration extends Configuration {
_onErrorClosure = (e) {
// TODO(vsm): figure out how to expose the stack trace here
// Currently e.message works in dartium, but not in dartc.
- notifyError('(DOM callback has errors) Caught ${e}', '');
+ reportTestError('(DOM callback has errors) Caught ${e}', '');
};
}
@@ -36,9 +36,11 @@ class HtmlConfiguration extends Configuration {
void onTestResult(TestCase testCase) {}
- void onDone(int passed, int failed, int errors, List<TestCase> results) {
+ void onDone(int passed, int failed, int errors, List<TestCase> results,
+ String uncaughtError) {
window.on.error.remove(_onErrorClosure);
- _showResultsInPage(passed, failed, errors, results, _isLayoutTest);
+ _showResultsInPage(passed, failed, errors, results, _isLayoutTest,
+ uncaughtError);
window.postMessage('unittest-suite-done', '*');
}
}
« no previous file with comments | « lib/unittest/dom_config.dart ('k') | lib/unittest/html_enhanced_config.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698