unittest step 3 and 4: remove TestFramework.dart, make test.dart use

tests/isolate/src/CountTest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("CountTest");
 #import('dart:isolate');
-#import("TestFramework.dart");
+#import('../../../lib/unittest/unittest.dart');
 
 class TestIsolate extends Isolate {
 
   TestIsolate() : super();
 
   void main() {
     int count = 0;
     this.port.receive((int message, SendPort replyTo) {
       if (message == -1) {
         Expect.equals(10, count);
         replyTo.send(-1, null);
         this.port.close();
         return;
       }
 
       Expect.equals(count, message);
       count++;
       replyTo.send(message * 2, null);
     });
   }
 }
 
-void test(TestExpectation expect) {
-  int count = 0;
-  expect.completes(new TestIsolate().spawn()).then((SendPort remote) {
-    ReceivePort local = new ReceivePort();
-    SendPort reply = local.toSendPort();
+void main() {
+  test("count 10 consecutive messages", () {
+    int count = 0;
+    new TestIsolate().spawn().then(later1((SendPort remote) {
+      ReceivePort local = new ReceivePort();
+      SendPort reply = local.toSendPort();
 
-    local.receive(expect.runs2((int message, SendPort replyTo) {

[Siggi Cherem (dart-lang), 2012/04/20 00:58:23]

this is called more than once, so 'later2' is not a good fit.

-      if (message == -1) {
-        Expect.equals(11, count);
-        local.close();
-        expect.succeeded();
-        return;
-      }
+      Function done = later0(() {});

[Bob Nystrom, 2012/04/20 22:31:36]

This is hackish. Either our API should support this pattern more gracefully or
there should be a comment here explaining what's going on.

[Siggi Cherem (dart-lang), 2012/04/21 00:03:43]

How about these names?
- calledOnce(f): replacing later(f), returns a function that we verify that will
be called only once
- callAtLeastOnce(f): returns a function that we will verify that is called at
least once.

In this scenario we'd need to do this:

Function done = calledOnce(() {}); // called when the test is done.
local.receive(calledAtLeastOnce2((int msg, SendPort reply) {
  ...
  if (/* last time */) {
     done();
  }
}));

+      local.receive((int message, SendPort replyTo) {
+        if (message == -1) {
+          Expect.equals(11, count);
+          local.close();
+          done();
+          return;
+        }
 
-      Expect.equals((count - 1) * 2, message);
+        Expect.equals((count - 1) * 2, message);
+        remote.send(count++, reply);
+        if (count == 10) {
+          remote.send(-1, reply);
+        }
+      });
       remote.send(count++, reply);
-      if (count == 10) {
-        remote.send(-1, reply);
-      }
     }));
-    remote.send(count++, reply);
   });
 }
-
-void main() {
-  runTests([test]);
-}
-
-
-