Get host id via getDaemonConfig.

Get host id via getDaemonConfig.

BUG=121518
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133509

[Jamie, 2012-04-19 23:58:43]

This is the web-app logic to get the host id from the host plugin. It depends on
the Windows host-side not requiring admin privileges, as discussed.

[simonmorris, 2012-04-23 17:29:18]

lgtm after one comment is addressed.

http://codereview.chromium.org/10152007/diff/1/remoting/webapp/host_controlle...
File remoting/webapp/host_controller.js (right):

http://codereview.chromium.org/10152007/diff/1/remoting/webapp/host_controlle...
remoting/webapp/host_controller.js:313: var hostId = config['host_id'];
It's less repetitive to test for hostId not being undefined. I think 'if
(hostId) { ... }' can replace the previous 'if'. For optional awesomeness, make
getHostForId map undefined to null, and remove the 'if' entirely.

[Jamie, 2012-04-23 20:24:24]

fyi

https://chromiumcodereview.appspot.com/10152007/diff/1/remoting/webapp/host_c...
File remoting/webapp/host_controller.js (right):

https://chromiumcodereview.appspot.com/10152007/diff/1/remoting/webapp/host_c...
remoting/webapp/host_controller.js:313: var hostId = config['host_id'];
On 2012/04/23 17:29:18, simonmorris wrote:
> It's less repetitive to test for hostId not being undefined. I think 'if
> (hostId) { ... }' can replace the previous 'if'. For optional awesomeness,
make
> getHostForId map undefined to null, and remove the 'if' entirely.

I want to check that host_id is a string, but you're right that there's no need
for an existence-check so I've removed that. I'm not sure I like the idea of
making getHostForId check for undefined, if only because it would effectively
make the hostId parameter optional (at least from a JSDoc point-of-view) and we
don't want that.

Of course, this is largely moot because getHostForId will return NULL for
anything the 'if' filters, and it's hard to imagine it ever doing anything else,
but I'd rather not rely on that.