Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 10144015: Convert session history ui test to a browser test, renabling all the disabled tests and got rid of … (Closed)

Created:
8 years, 8 months ago by jam
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Convert session history ui test to a browser test, renabling all the disabled tests and got rid of flaky patterns. Hopefully they don't fail again. BUG=121574, 102094, 48833, 45058, 50648, 22560, 22111, 56267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133458

Patch Set 1 #

Patch Set 2 : actually move test to content since it's testing web platform #

Patch Set 3 : readd history test (this isn't session history) #

Patch Set 4 : readd history test (this isn't session history) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -882 lines) Patch
M chrome/browser/history/history_browsertest.cc View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
D chrome/browser/session_history_uitest.cc View 1 chunk +0 lines, -567 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/session_history_browsertest.cc View 1 5 chunks +213 lines, -314 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
8 years, 8 months ago (2012-04-21 18:00:40 UTC) #1
nsylvain
This seems fine, but I don't think I'm the best person to review this (i'm ...
8 years, 8 months ago (2012-04-21 22:26:07 UTC) #2
jam
Joi: can you take a look?
8 years, 8 months ago (2012-04-23 14:47:17 UTC) #3
Jói
8 years, 8 months ago (2012-04-23 14:58:37 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698