Issue 10141007: Make --stress-compaction more stressful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10141007: Make --stress-compaction more stressful. (Closed)

Created:
8 years, 8 months ago by Erik Corry

Modified:
8 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Make --stress-compaction more stressful. Committed: https://code.google.com/p/v8/source/detail?r=11431

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -2 lines)			Patch
M	src/heap.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	3 chunks	+14 lines, -1 line	0 comments	Download
M	src/spaces-inl.h	View	1 chunk	+15 lines, -1 line	1 comment	Download
M	test/mjsunit/regexp-capture-3.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 8 months ago (2012-04-24 11:39:15 UTC) #2

LGTM (with a nit).

https://chromiumcodereview.appspot.com/10141007/diff/1/src/spaces-inl.h
File src/spaces-inl.h (right):

https://chromiumcodereview.appspot.com/10141007/diff/1/src/spaces-inl.h#newco...
src/spaces-inl.h:300: if (allocation_info_.limit - old_top >= size_in_bytes * 4)
{
Could you add a one-liner comment why it helps to have holes in new-space when
stressing compaction?

Expand Messages | Collapse Messages