Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: chrome/test/data/webui/ntp4.js

Issue 10141005: switch ntp to jstemplate v2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update test Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/jstemplate_builder.h ('K') | « chrome/common/jstemplate_builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/ntp4.js
diff --git a/chrome/test/data/webui/ntp4.js b/chrome/test/data/webui/ntp4.js
index a4a020802584e0f437a281a5dad65bf64fadedf7..02cf5747f50e02925de7e048d4fac5011002d302 100644
--- a/chrome/test/data/webui/ntp4.js
+++ b/chrome/test/data/webui/ntp4.js
@@ -36,7 +36,7 @@ TEST_F('NTP4WebUITest', 'FLAKY_NTPHasThumbnails', function() {
assertEquals(8, mostVisited.length, 'There should be 8 most visited tiles.');
var apps = document.querySelectorAll('.app');
- if (window.templateData.showApps)
+ if (window.loadTimeData['showApps'])
Dan Beam 2012/04/25 23:13:12 er, what? shouldn't this be loadTimeData.getBoolea
Evan Stade 2012/04/26 00:44:56 correct question is why am I not using getBoolean.
assertGE(apps.length, 1, 'There should be at least one app.');
else
assertEquals(0, apps.length, 'There should be no apps.');
@@ -44,7 +44,7 @@ TEST_F('NTP4WebUITest', 'FLAKY_NTPHasThumbnails', function() {
TEST_F('NTP4WebUITest', 'NTPHasNavDots', function() {
var navDots = document.querySelectorAll('.dot');
- if (window.templateData.showApps)
+ if (window.loadtimeData['showApps'])
assertGE(navDots.length, 2, 'There should be at least two navdots.');
else
assertEquals(1, navDots.length, 'There should be exactly one navdot.');
« chrome/common/jstemplate_builder.h ('K') | « chrome/common/jstemplate_builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698