switch ntp to jstemplate v2

chrome/browser/resources/shared/js/load_time_data.js

Index: chrome/browser/resources/shared/js/load_time_data.js
diff --git a/chrome/browser/resources/shared/js/load_time_data.js b/chrome/browser/resources/shared/js/load_time_data.js
index 77aa490e7cfd3e414d7aa08bc836a912767d6ebd..66a83f44ead58da0f1038dfb98db9ea5a1b85077 100644
--- a/chrome/browser/resources/shared/js/load_time_data.js
+++ b/chrome/browser/resources/shared/js/load_time_data.js
@@ -29,6 +29,13 @@ var loadTimeData;
     },
 
     /**
+     * @return {boolean} True if |id| is a key in the dictionary.
+     */
+    valueExists: function(id) {
+      return id in this.data_;
+    },
+
+    /**
      * Fetches a value, asserting that it exists.
      * @param {string} id The key that identifies the desired value.
      * @return {*} The corresponding value.
@@ -47,8 +54,30 @@ var loadTimeData;
      */
     getString: function(id) {
       var value = this.getValue(id);
-      assert(typeof value == 'string', '[' + value + '] (' + id +
-                                       ') is not a string');
+      assertIsType(id, value, 'string');
+      return value;
+    },
+
+    /**
+     * As above, but also makes sure that the value is a boolean.
+     * @param {string} id The key that identifies the desired boolean.
+     * @return {boolean} The corresponding boolean value.
+     */
+    getBoolean: function(id) {
+      var value = this.getValue(id);
+      assertIsType(id, value, 'boolean');
+      return value;
+    },
+
+    /**
+     * As above, but also makes sure that the value is an integer.
+     * @param {string} id The key that identifies the desired number.
+     * @return {number} The corresponding number value.
+     */
+    getInteger: function(id) {

[Dan Beam, 2012/04/25 23:13:12]

Why getInteger() instead of getNumber()?

[Evan Stade, 2012/04/26 00:44:56]

why getNumber? there's a difference in C++ (where this data is coming from), and
in theory.

[Dan Beam, 2012/04/26 01:41:29]

I'm still slightly leary of depending on floating point precision here, but
we'll see what happens (we'll get warned from tests if there's an issue).

+      var value = this.getValue(id);
+      assertIsType(id, value, 'number');
+      assert(value == Math.floor(value), 'Number isn\'t integer: ' + value);
       return value;
     },
   };
@@ -64,6 +93,17 @@ var loadTimeData;
     }
   }
 
+  /**
+   * Asserts that the given value has the given type.
+   * @param {string} id The id of the value (only used for error message).
+   * @param {*} value The value to check the type on.
+   * @param {string} type The type we expect |value| to be.
+   */
+  function assertIsType(id, value, type) {
+    assert(typeof value == type, '[' + value + '] (' + id +
+                                 ') is not a ' + type);
+  }
+
   assert(!loadTimeData, 'should only include this file once');
   loadTimeData = new LoadTimeData;
 })();