switch ntp to jstemplate v2

chrome/browser/ui/webui/ntp/ntp_login_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_login_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 239 matching lines @@
     return false;
 
   return profile->GetOriginalProfile()->IsSyncAccessible();
 #endif
 }
 
 // static
 void NTPLoginHandler::GetLocalizedValues(Profile* profile,
                                          DictionaryValue* values) {
   PrefService* prefs = profile->GetPrefs();
-  if (prefs->GetString(prefs::kGoogleServicesUsername).empty() ||
-      !prefs->GetBoolean(prefs::kSyncPromoShowNTPBubble)) {
-    return;
-  }
+  bool hide_sync = prefs->GetString(prefs::kGoogleServicesUsername).empty() ||

[Dan Beam, 2012/04/25 23:13:12]

why did you change this?

[Evan Stade, 2012/04/26 00:44:56]

because http://code.google.com/p/chromium/issues/detail?id=124081

+      !prefs->GetBoolean(prefs::kSyncPromoShowNTPBubble);
 
   values->SetString("login_status_message",
+      hide_sync ? string16() :
       l10n_util::GetStringFUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_MESSAGE,
           l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME)));
-  values->SetString("login_status_url", chrome::kSyncLearnMoreURL);
-  values->SetString("login_status_learn_more",
-      l10n_util::GetStringUTF16(IDS_LEARN_MORE));
+  values->SetString("login_status_url",
+      hide_sync ? std::string() : chrome::kSyncLearnMoreURL);
   values->SetString("login_status_advanced",
+      hide_sync ? string16() :
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_ADVANCED));
   values->SetString("login_status_dismiss",
+      hide_sync ? string16() :
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_OK));
 }