Avoid "=== true" inside code by calling a function that does this for us.

lib/compiler/implementation/lib/js_helper.dart

Index: lib/compiler/implementation/lib/js_helper.dart
diff --git a/lib/compiler/implementation/lib/js_helper.dart b/lib/compiler/implementation/lib/js_helper.dart
index 7dbccc9254214c0a35c9875ed25512e6891f7edd..5d5e4a706c6233c18af0bf5b925bae4ec38166c0 100644
--- a/lib/compiler/implementation/lib/js_helper.dart
+++ b/lib/compiler/implementation/lib/js_helper.dart
@@ -96,7 +96,7 @@ tdiv(var a, var b) {
 eq(var a, var b) {
   if (JS('bool', @'typeof # === "object"', a)) {
     if (JS_HAS_EQUALS(a)) {
-      return UNINTERCEPTED(a == b) === true;

[ngeoffray, 2012/04/25 11:48:08]

The true comparison is evil here, could you write a test that shows it?

[floitsch, 2012/04/25 16:01:49]

was on my agenda.
done.

+      return UNINTERCEPTED(a == b);
     } else {
       return JS('bool', @'# === #', a, b);
     }
@@ -105,6 +105,8 @@ eq(var a, var b) {
   return JS('bool', @'# === #', a, b);
 }
 
+bool eqB(var a, var b) => eq(a, b) === true;
+
 eqq(var a, var b) {
   return JS('bool', @'# === #', a, b);
 }
@@ -121,6 +123,8 @@ eqNull(var a) {
   }
 }
 
+bool eqNullB(var a) => eqNull(a) === true;
+
 gt(var a, var b) {
   if (checkNumbers(a, b)) {
     return JS('bool', @'# > #', a, b);
@@ -128,6 +132,8 @@ gt(var a, var b) {
   return UNINTERCEPTED(a > b);
 }
 
+bool gtB(var a, var b) => gt(a, b) === true;
+
 ge(var a, var b) {
   if (checkNumbers(a, b)) {
     return JS('bool', @'# >= #', a, b);
@@ -135,6 +141,8 @@ ge(var a, var b) {
   return UNINTERCEPTED(a >= b);
 }
 
+bool geB(var a, var b) => ge(a, b) === true;
+
 lt(var a, var b) {
   if (checkNumbers(a, b)) {
     return JS('bool', @'# < #', a, b);
@@ -142,6 +150,8 @@ lt(var a, var b) {
   return UNINTERCEPTED(a < b);
 }
 
+bool ltB(var a, var b) => lt(a, b) === true;
+
 le(var a, var b) {
   if (checkNumbers(a, b)) {
     return JS('bool', @'# <= #', a, b);
@@ -149,6 +159,8 @@ le(var a, var b) {
   return UNINTERCEPTED(a <= b);
 }
 
+bool leB(var a, var b) => le(a, b) === true;
+
 shl(var a, var b) {
   // TODO(floitsch): inputs must be integers.
   if (checkNumbers(a, b)) {