Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: frog/tests/leg/src/BoolifiedOperatorTest.dart

Issue 10140027: Avoid "=== true" inside code by calling a function that does this for us. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Change copyright year. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/tests/leg/src/ConstantFoldingTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/tests/leg/src/BoolifiedOperatorTest.dart
diff --git a/frog/tests/leg/src/BoolifiedOperatorTest.dart b/frog/tests/leg/src/BoolifiedOperatorTest.dart
new file mode 100644
index 0000000000000000000000000000000000000000..02027f979a4d8d22f99f7a0ef3a6bf7a0e51869d
--- /dev/null
+++ b/frog/tests/leg/src/BoolifiedOperatorTest.dart
@@ -0,0 +1,74 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#import("compiler_helper.dart");
+
+final String TEST_EQUAL = @"""
+foo(param0, param1) {
+ if (param0 == param1) return 0;
+ return 1;
+}
+""";
+
+final String TEST_EQUAL_NULL = @"""
+foo(param0) {
+ if (param0 == null) return 0;
+ return 1;
+}
+""";
+
+final String TEST_LESS = @"""
+foo(param0, param1) {
+ if (param0 < param1) return 0;
+ return 1;
+}
+""";
+
+final String TEST_LESS_EQUAL = @"""
+foo(param0, param1) {
+ if (param0 <= param1) return 0;
+ return 1;
+}
+""";
+final String TEST_GREATER = @"""
+foo(param0, param1) {
+ if (param0 > param1) return 0;
+ return 1;
+}
+""";
+
+final String TEST_GREATER_EQUAL = @"""
+foo(param0, param1) {
+ if (param0 >= param1) return 0;
+ return 1;
+}
+""";
+
+main() {
+ RegExp regexp = const RegExp('=== true');
+
+ String generated = compile(TEST_EQUAL, 'foo');
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('eqB'));
+
+ generated = compile(TEST_EQUAL_NULL, 'foo');
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('eqNullB'));
+
+ generated = compile(TEST_LESS, 'foo');
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('ltB'));
+
+ generated = compile(TEST_LESS_EQUAL, 'foo');
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('leB'));
+
+ generated = compile(TEST_GREATER, 'foo');
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('gtB'));
+
+ generated = compile(TEST_GREATER_EQUAL, 'foo');
+ Expect.isFalse(generated.contains('=== true'));
+ Expect.isTrue(generated.contains('geB'));
+}
« no previous file with comments | « no previous file | frog/tests/leg/src/ConstantFoldingTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698