Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: tests/language/src/Operator5Test.dart

Issue 10140027: Avoid "=== true" inside code by calling a function that does this for us. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove super.getter since dart2js doesn't support it yet. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/src/Operator5Test.dart
diff --git a/tests/language/src/Operator5Test.dart b/tests/language/src/Operator5Test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..0dbf960d6929052664024ca678dada6ee1256499
--- /dev/null
+++ b/tests/language/src/Operator5Test.dart
@@ -0,0 +1,61 @@
+// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
ngeoffray 2012/04/26 08:40:00 2011 -> 2012
floitsch 2012/04/26 10:36:09 Done.
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+class A {
+ operator ==(other) => 1;
+ operator <(other) => null;
+ operator <=(other) => 499;
+ operator >(other) => "foo";
+ operator >=(other) => 42;
+}
+
+// This triggered a bug in Dart2Js: equality operator was always boolified.
+equals(a) {
+ try {
+ Expect.equals(1, a == a);
+ } catch(TypeError e) {
+ // In checked mode the test doesn't do anything.
+ }
+}
+
+equalsNull(a) {
+ try {
+ Expect.equals(1, a == null);
+ } catch(TypeError e) {
+ // In checked mode the test doesn't do anything.
+ }
+}
+
+less(a) {
+ try {
+ Expect.equals(null, a < a);
+ } catch(TypeError e) {}
+}
+
+lessEqual(a) {
+ try {
+ Expect.equals(499, a <= a);
+ } catch(TypeError e) {}
+}
+
+greater(a) {
+ try {
+ Expect.equals("foo", a > a);
+ } catch(TypeError e) {}
+}
+
+greaterEqual(a) {
+ try {
+ Expect.equals(42, a >= a);
+ } catch(TypeError e) {}
+}
+
+main() {
+ var a = new A();
+ equals(a);
+ less(a);
+ lessEqual(a);
+ greater(a);
+ greaterEqual(a);
+}
« lib/compiler/implementation/ssa/nodes.dart ('K') | « lib/compiler/implementation/ssa/optimize.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698