Issue 10140023: [File Manager] Welcome to Google Docs banner

Issue 10140023: [File Manager] Welcome to Google Docs banner (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev

Modified:
8 years, 8 months ago

Reviewers:
James Hawkins, SeRya

CC:
chromium-reviews, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[File Manager] Welcome to Google Docs banner BUG=chromium-os:28807 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133910

Patch Set 1 #

Patch Set 2 : Added Google Drive logo, updated strings #

Total comments: 4

Patch Set 3 : Extracted css into a dynamically loaded file #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+296 lines, -24 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+32 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/component_extension_resources.grd	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/css/file_manager.css	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/css/gdrive_welcome.css	View	1 2	1 chunk	+124 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/clouds.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/gdrive_logo.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	5 chunks	+109 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1	2 chunks	+17 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

Hi, Sergey, please review the whole patch. James, please review the change to component_extension_resources.grd (sorry, ...

8 years, 8 months ago (2012-04-24 20:17:19 UTC) #1

SeRya

lgtm https://chromiumcodereview.appspot.com/10140023/diff/5001/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://chromiumcodereview.appspot.com/10140023/diff/5001/chrome/browser/resources/file_manager/css/file_manager.css#newcode1166 chrome/browser/resources/file_manager/css/file_manager.css:1166: /* Google Docs welcome banners.*/ I think 150 ...

8 years, 8 months ago (2012-04-25 14:09:55 UTC) #3

Vladislav Kaznacheev

8 years, 8 months ago (2012-04-25 14:41:59 UTC) #4

https://chromiumcodereview.appspot.com/10140023/diff/5001/chrome/browser/reso...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/10140023/diff/5001/chrome/browser/reso...
chrome/browser/resources/file_manager/css/file_manager.css:1166: /* Google Docs
welcome banners.*/
On 2012/04/25 14:09:56, SeRya wrote:
> I think 150 lines of CSS what is used once need to be loaded dynamically on
> demand.

Done.

https://chromiumcodereview.appspot.com/10140023/diff/5001/chrome/browser/reso...
chrome/browser/resources/file_manager/css/file_manager.css:1178:
background-image: url('../images/common/close_x_gray.png');
On 2012/04/25 14:09:56, SeRya wrote:
> We should kill this icon and use shared x.png/x-hover.png from shared
resources
> for consistency.

Done.

Expand Messages | Collapse Messages