Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: dart/lib/dartdoc/dartdoc.dart

Issue 10140021: Revert "Use 'frog' in apidoc. Also fix broken dependencies." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/lib/dartdoc/client-live-nav.dart ('k') | dart/utils/apidoc/apidoc.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/dartdoc/dartdoc.dart
diff --git a/dart/lib/dartdoc/dartdoc.dart b/dart/lib/dartdoc/dartdoc.dart
index 88a6c22ba3baa8e07bca7775b612c5a454163ded..57191283f9718f3c214726e17a676fc2e7f09cf6 100644
--- a/dart/lib/dartdoc/dartdoc.dart
+++ b/dart/lib/dartdoc/dartdoc.dart
@@ -175,27 +175,17 @@ void copyFiles(String from, String to) {
*/
void compileScript(String compilerPath, String libDir,
String dartPath, String jsPath) {
- onExit(int exitCode, String stdout, String stderr) {
- if (exitCode != 0) {
- final message = 'Non-zero exit code from $compilerPath';
- print('$message.');
- print(stdout);
- print(stderr);
- throw message;
- }
- }
-
- onError(error) {
- final message = 'Error trying to execute $compilerPath. Error: $error';
- print('$message.');
- throw message;
- }
-
- print('Compiling $dartPath to $jsPath');
- new Process.run(compilerPath, [
+ final process = new Process.start(compilerPath, [
'--libdir=$libDir', '--out=$jsPath',
'--compile-only', '--enable-type-checks', '--warnings-as-errors',
- dartPath], null, onExit).onError = onError;
+ dartPath]);
+
+ process.stdout.pipe(stdout, close: false);
+
+ process.onError = (error) {
+ print('Failed to compile $dartPath with $compilerPath. Error:');
+ print(error);
+ };
}
class Dartdoc {
« no previous file with comments | « dart/lib/dartdoc/client-live-nav.dart ('k') | dart/utils/apidoc/apidoc.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698