Issue 10140017: ash: Some code-cleanup in the system-tray code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10140017: ash: Some code-cleanup in the system-tray code. (Closed)

Created:
8 years, 8 months ago by sadrul

Modified:
8 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Some code-cleanup in the system-tray code. Move the remaining status-area code into system-tray. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133686

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+135 lines, -264 lines)			Patch
M	ash/ash.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/focus_cycler_unittest.cc	View	10 chunks	+28 lines, -21 lines	0 comments	Download
M	ash/shell.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	ash/shell.cc	View	5 chunks	+8 lines, -64 lines	2 comments	Download
D	ash/status_area/status_area_view.h	View	1 chunk	+0 lines, -49 lines	0 comments	Download
D	ash/status_area/status_area_view.cc	View	1 chunk	+0 lines, -93 lines	0 comments	Download
M	ash/system/tray/system_tray.h	View	4 chunks	+11 lines, -2 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	3 chunks	+81 lines, -0 lines	0 comments	Download
A +	ash/system/tray/system_tray_widget_delegate.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ash/system/tray/system_tray_widget_delegate.cc	View	2 chunks	+1 line, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm http://codereview.chromium.org/10140017/diff/1/ash/shell.cc File ash/shell.cc (right): http://codereview.chromium.org/10140017/diff/1/ash/shell.cc#newcode671 ash/shell.cc:671: tray_.reset(new SystemTray()); food for thought (and a different ...

8 years, 8 months ago (2012-04-24 14:57:48 UTC) #2

sadrul

8 years, 8 months ago (2012-04-24 15:36:55 UTC) #3

Thanks!

http://codereview.chromium.org/10140017/diff/1/ash/shell.cc
File ash/shell.cc (right):

http://codereview.chromium.org/10140017/diff/1/ash/shell.cc#newcode671
ash/shell.cc:671: tray_.reset(new SystemTray());
On 2012/04/24 14:57:49, Ben Goodger (Google) wrote:
> food for thought (and a different CL)
> 
> ideally it'd be possible to simply all tray setup to a single line in this
file.

Indeed. That would allow us to move DummySystemTrayDelegate out of this file
too. I will take a TODO for that.

Expand Messages | Collapse Messages