Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 10139027: Set svn:executable bit on scripts that are executable. (Closed)

Created:
8 years, 8 months ago by M-A Ruel
Modified:
8 years, 8 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Reset the svn:executable bit on scripts that are not executable. R=nick@chromium.org BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A net/tools/testserver/chromiumsync.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
8 years, 8 months ago (2012-04-23 02:14:29 UTC) #1
ncarter (slow)
Sure, LGTM, though this is a library.
8 years, 8 months ago (2012-04-23 05:05:07 UTC) #2
M-A Ruel
On 2012/04/23 05:05:07, ncarter wrote: > Sure, LGTM, though this is a library. Oh right, ...
8 years, 8 months ago (2012-04-23 12:53:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10139027/1
8 years, 8 months ago (2012-04-23 12:53:12 UTC) #4
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
8 years, 8 months ago (2012-04-23 14:13:42 UTC) #5
M-A Ruel
8 years, 8 months ago (2012-04-23 14:16:02 UTC) #6
On 2012/04/23 14:13:42, I haz the power (commit-bot) wrote:
> Commit queue had an internal error.
> Something went really wrong, probably a crash, a hickup or
> simply the monkeys went out for dinner.
> The relevant dude was pinged already.

The CQ doesn't like that there is no file content modification so I'll commit
manually.

Powered by Google App Engine
This is Rietveld 408576698