Refactor types in ssa nodes.

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
 
   String generateMethod(WorkItem work, HGraph graph) {
@@ skipping 1470 matching lines @@
   }
 
   void checkImmutableArray(HInstruction input) {
     beginExpression(JSPrecedence.PREFIX_PRECEDENCE);
     buffer.add('!!');
     use(input, JSPrecedence.MEMBER_PRECEDENCE);
     buffer.add('.immutable\$list');
     endExpression(JSPrecedence.PREFIX_PRECEDENCE);
   }
 
+  void checkExtendableArray(HInstruction input) {
+    compiler.unimplemented("check extendable array");
+  }
+
   void checkNull(HInstruction input) {
     beginExpression(JSPrecedence.EQUALITY_PRECEDENCE);
     use(input, JSPrecedence.EQUALITY_PRECEDENCE);
     buffer.add(" === (void 0)");
     endExpression(JSPrecedence.EQUALITY_PRECEDENCE);
   }
 
   void checkFunction(HInstruction input, Element element) {
     beginExpression(JSPrecedence.LOGICAL_OR_PRECEDENCE);
     beginExpression(JSPrecedence.EQUALITY_PRECEDENCE);
@@ skipping 168 matching lines @@
     } else if (node.isBoolean()) {
       buffer.add('if (');
       checkBool(input, '!==');
       buffer.add(') ');
       bailout(node, 'Not a boolean');
     } else if (node.isString()) {
       buffer.add('if (');
       checkString(input, '!==');
       buffer.add(') ');
       bailout(node, 'Not a string');
+    } else if (node.isExtendableArray()) {
+      buffer.add('if (');
+      checkObject(input, '!==');
+      buffer.add('||');
+      checkArray(input, '!==');
+      buffer.add('||');
+      checkExtendableArray(input);
+      buffer.add(') ');
+      bailout(node, 'Not an extendable array');
     } else if (node.isMutableArray()) {
       buffer.add('if (');
       checkObject(input, '!==');
       buffer.add('||');
       checkArray(input, '!==');
       buffer.add('||');
       checkImmutableArray(input);
       buffer.add(') ');
       bailout(node, 'Not a mutable array');
-    } else if (node.isArray()) {
+    } else if (node.isReadableArray()) {
       buffer.add('if (');
       checkObject(input, '!==');
       buffer.add('||');
       checkArray(input, '!==');
       buffer.add(') ');
       bailout(node, 'Not an array');
-    } else if (node.isStringOrArray()) {
+    } else if (node.isIndexablePrimitive()) {
       buffer.add('if (');
       checkString(input, '!==');
       buffer.add(' && (');
       checkObject(input, '!==');
       buffer.add('||');
       checkArray(input, '!==');
       buffer.add(')) ');
       bailout(node, 'Not a string or array');
     } else {
       unreachable();
@@ skipping 270 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endElse(HIf node) {
     if (node.elseBlock.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }