Remove SpdyFramer::CompressFrame() and use CompressControlFrame instead.

net/spdy/spdy_framer.cc

Index: net/spdy/spdy_framer.cc
diff --git a/net/spdy/spdy_framer.cc b/net/spdy/spdy_framer.cc
index 4d4a25f4143f6cb89a1c75def34fe8c0724c78d5..97474017ef918b14033f38503548a8efd522f003 100644
--- a/net/spdy/spdy_framer.cc
+++ b/net/spdy/spdy_framer.cc
@@ -1272,14 +1272,6 @@ static const int kCompressorLevel = 9;
 static const int kCompressorWindowSizeInBits = 11;
 static const int kCompressorMemLevel = 1;
 
-SpdyFrame* SpdyFramer::CompressFrame(const SpdyFrame& frame) {
-  if (frame.is_control_frame()) {
-    return CompressControlFrame(
-        reinterpret_cast<const SpdyControlFrame&>(frame));
-  }
-  return NULL;
-}
-
 bool SpdyFramer::IsCompressible(const SpdyFrame& frame) const {
   // The important frames to compress are those which contain large
   // amounts of compressible data - namely the headers in the SYN_STREAM
@@ -1288,7 +1280,8 @@ bool SpdyFramer::IsCompressible(const SpdyFrame& frame) const {
     const SpdyControlFrame& control_frame =
         reinterpret_cast<const SpdyControlFrame&>(frame);
     return control_frame.type() == SYN_STREAM ||
-           control_frame.type() == SYN_REPLY;
+           control_frame.type() == SYN_REPLY ||
+           control_frame.type() == HEADERS;

[hkhalil, 2012/04/19 21:12:59]

Should probably be a separate change so that it's easier to roll back, track,
etc. Up to you.

[hkhalil, 2012/04/19 21:12:59]

Regression test for this bug?

[Ryan Hamilton, 2012/04/19 21:14:55]

I added one in spdy_framer_test.cc :>

[Ryan Hamilton, 2012/04/19 21:14:55]

I think it'll just as easy to do in a single CL since the server side doesn't
have this function at all...

[hkhalil, 2012/04/19 21:15:48]

I mean in an end-to-end test...

   }
 
   // We don't compress Data frames.