Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/testing/perf_testing/run_perf_tests.py

Issue 10134070: Get get_drt working on Windows, take 2. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/get_drt.py ('K') | « tools/get_drt.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/run_perf_tests.py
===================================================================
--- tools/testing/perf_testing/run_perf_tests.py (revision 6977)
+++ tools/testing/perf_testing/run_perf_tests.py (working copy)
@@ -412,7 +412,8 @@
'--dartium']
# TODO(vsm): It's inconvenient that run_cmd isn't in scope here.
# Perhaps there is a better place to put that or this.
- subprocess.Popen(get_dartium, shell=has_shell)
+ subprocess.call(get_dartium, stdout=sys.stdout, stderr=sys.stderr,
+ shell=has_shell)
return browsers
@@ -634,7 +635,7 @@
self.test.test_runner.run_cmd(
['python', os.path.join('tools', 'testing', 'run_selenium.py'),
'--out', file_path, '--browser', browser,
- '--timeout', '600', '--mode', 'dromaeo'], self.test.trace_file,
+ '--timeout', '900', '--mode', 'dromaeo'], self.test.trace_file,
append=True)
@staticmethod
« tools/get_drt.py ('K') | « tools/get_drt.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698