Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Unified Diff: src/tools/validator_tools/ncstubout.c

Issue 10134056: Refactor the process of choosing validators. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: more aesthetics Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/tools/validator_tools/build.scons ('k') | src/trusted/service_runtime/build.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/tools/validator_tools/ncstubout.c
diff --git a/src/tools/validator_tools/ncstubout.c b/src/tools/validator_tools/ncstubout.c
index e2ae7e15874b63965b46817127ffe35be9ea8538..8b018ad1eeda015596efc93de79d523867a23227 100644
--- a/src/tools/validator_tools/ncstubout.c
+++ b/src/tools/validator_tools/ncstubout.c
@@ -29,15 +29,13 @@ static Bool FixUpSection(uintptr_t load_address,
size_t code_size) {
NaClValidationStatus status;
NaClCPUFeatures cpu_features;
+ const struct NaClValidatorInterface *validator = NaClCreateValidator();
/* Pretend that the CPU supports every feature so that we will only stub out
* instructions that NaCl will never allow under any condition.
*/
NaClSetAllCPUFeatures(&cpu_features);
- status = NACL_SUBARCH_NAME(ApplyValidator,
- NACL_TARGET_ARCH,
- NACL_TARGET_SUBARCH)
- (load_address, code, code_size,
+ status = validator->Validate(load_address, code, code_size,
/* stubout_mode= */ TRUE, /* readonly_text= */ FALSE,
&cpu_features, NULL);
if (status == NaClValidationSucceeded) {
« no previous file with comments | « src/tools/validator_tools/build.scons ('k') | src/trusted/service_runtime/build.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698