Refactor the process of choosing validators.

src/trusted/validator/x86/ncval_seg_sfi/ncdecode.h

Index: src/trusted/validator/x86/ncval_seg_sfi/ncdecode.h
diff --git a/src/trusted/validator/x86/ncval_seg_sfi/ncdecode.h b/src/trusted/validator/x86/ncval_seg_sfi/ncdecode.h
index 186f3d515f898ca44ccae85b2e8c8f7abbf090e4..cf4f87663e00c93d0fc469ec76fa70c8182ec931 100644
--- a/src/trusted/validator/x86/ncval_seg_sfi/ncdecode.h
+++ b/src/trusted/validator/x86/ncval_seg_sfi/ncdecode.h
@@ -14,6 +14,7 @@
 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVAL_SEG_SFI_NCDECODE_H_
 
 #include "native_client/src/shared/utils/types.h"
+#include "native_client/src/trusted/validator/ncvalidate.h"
 #include "native_client/src/trusted/validator/x86/error_reporter.h"
 #include "native_client/src/trusted/validator/x86/ncinstbuffer.h"
 #include "native_client/src/trusted/validator/x86/x86_insts.h"
@@ -385,6 +386,11 @@ typedef struct NCDecoderStatePair {
 
   /* The (virtual method) action to apply to each instruction. */
   NCDecoderStatePairAction action_fn;
+
+  /* Utility function that copies a single instruction in memory, can be used in
+   * actions.
+   */
+  NaClCopyInstructionFunc copy_func;
 } NCDecoderStatePair;
 
 /*
@@ -398,9 +404,11 @@ typedef struct NCDecoderStatePair {
  * Note: Constructors of subclasses of NCDecoderStatePair should
  * call this constructor first, to initialize the decoder pair fields.
  */
-extern void NCDecoderStatePairConstruct(NCDecoderStatePair* tthis,
-                                        NCDecoderState* old_dstate,
-                                        NCDecoderState* new_dstate);
+extern void NCDecoderStatePairConstruct(
+    NCDecoderStatePair* tthis,
+    NCDecoderState* old_dstate,
+    NCDecoderState* new_dstate,
+    const NaClCopyInstructionFunc copy_func);

[Mark Seaborn, 2012/06/20 20:02:26]

Here is another instance of an unnecessary const.  Please grep the patch for
"const NaClCopyInstructionFunc" and fix all cases.

[pasko-google - do not use, 2012/06/21 15:24:18]

Sorry, now done throughout the patch

 
 /*
  * Decode the memory segments in each instruction state, applying