src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c - Issue 10134056: Refactor the process of choosing validators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c

Issue 10134056: Refactor the process of choosing validators. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebased, added a todo for NaClCopyCode Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c

diff --git a/src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c b/src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c

index e1e3ccfb3564b4c312b5ce923b3938bcd59a5d28..07e49a35f030673595a43d6321b1da6ad665f427 100644

--- a/src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c

+++ b/src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c

@@ -685,10 +685,12 @@ static Bool NullNCDecoderStatePairAction(struct NCDecoderStatePair* tthis,

void NCDecoderStatePairConstruct(NCDecoderStatePair* tthis,

NCDecoderState* old_dstate,

- NCDecoderState* new_dstate) {

+ NCDecoderState* new_dstate,

+ const NaClCopyInstructionFunc copy_func) {

tthis->old_dstate = old_dstate;

tthis->new_dstate = new_dstate;

tthis->action_fn = NullNCDecoderStatePairAction;

+ tthis->copy_func = copy_func;

}

void NCDecoderStatePairDestruct(NCDecoderStatePair* tthis) {