Refactor the process of choosing validators.

src/trusted/validator/ncvalidate.h

Index: src/trusted/validator/ncvalidate.h
diff --git a/src/trusted/validator/ncvalidate.h b/src/trusted/validator/ncvalidate.h
index a46e6960814f49ed0fbd0036ab1a21303d1fc7bf..390fa9714b2aa04479c95deb368b0a6902ac15b5 100644
--- a/src/trusted/validator/ncvalidate.h
+++ b/src/trusted/validator/ncvalidate.h
@@ -31,32 +31,15 @@
 #include "native_client/src/include/nacl_base.h"
 #include "native_client/src/shared/utils/types.h"
 #include "native_client/src/trusted/validator/cpufeatures.h"
+#include "native_client/src/trusted/validator/validation_status.h"
 
 EXTERN_C_BEGIN
 
 struct NaClValidationCache;
 
-/* Defines possible validation status values. */

[Nick Bray, 2012/04/25 20:57:42]

See previous comments, it may make sense to keep the enum here.

[pasko-google - do not use, 2012/04/26 15:17:01]

Done.

-typedef enum NaClValidationStatus {
-  /* The call to the validator succeeded. */
-  NaClValidationSucceeded,
-  /* The call to the validator failed (Reason unspecified) */
-  NaClValidationFailed,
-  /* The call to the validator failed, due to not enough memory. */
-  NaClValidationFailedOutOfMemory,
-  /* The call to the validator failed, due to it not being implemented yet. */
-  NaClValidationFailedNotImplemented,
-  /* The call to the validator failed, because the CPU is not supported. */
-  NaClValidationFailedCpuNotSupported,
-  /* The call to the validator failed, due to segment alignment issues. */
-  NaClValidationFailedSegmentationIssue
-} NaClValidationStatus;
-
 /* Applies the validator, as defined by sel_ldr. That is, run the
  * validator where performance is critical.
  * Parameters are:
- *    local_cpu: True if local cpu rules should be applied.
- *           Otherwise, assume no cpu specific rules.
  *    guest_addr - The virtual pc to assume with the beginning address of the
  *           code segment. Typically, this is the corresponding addresss that
  *           will be used by objdump.
@@ -106,8 +89,6 @@ extern NaClValidationStatus NACL_SUBARCH_NAME(ApplyDfaValidator,
  * Note: This is intentionally separated from ApplyValidator, since it need
  * not be performance critical.
  * Parameters are:
- *    local_cpu: True if local cpu rules should be applied.
- *           Otherwise, assume no cpu specific rules.
  *    guest_addr - The virtual pc to assume with the beginning address of the
  *           code segment. Typically, this is the corresponding addresss that
  *           will be used by objdump.