src/trusted/service_runtime/sel_main_chrome.c - Issue 10134056: Refactor the process of choosing validators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/sel_main_chrome.c

Issue 10134056: Refactor the process of choosing validators. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: draft that does not fully build Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/service_runtime/sel_main_chrome.c

diff --git a/src/trusted/service_runtime/sel_main_chrome.c b/src/trusted/service_runtime/sel_main_chrome.c

index 162073ff7f688dcd7b452b669e61514e7d3a69f5..f05054f898a117d1fc464cd98af8662fda67e64a 100644

--- a/src/trusted/service_runtime/sel_main_chrome.c

+++ b/src/trusted/service_runtime/sel_main_chrome.c

@@ -130,10 +130,7 @@ void NaClChromeMainStart(struct NaClChromeMainArgs *args) {

NaClSetBrokerDuplicateHandleFunc(args->broker_duplicate_handle_func);

#endif

- if (getenv("NACL_DANGEROUS_USE_DFA_VALIDATOR") != NULL) {

- fprintf(stderr, "DANGER! USING THE UNSTABLE DFA VALIDATOR!\n");

- nap->enable_dfa_validator = 1;

- }

+ NaClSelectValidator(&nap->validator);

NaClAppInitialDescriptorHookup(nap);