Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: src/trusted/service_runtime/build.scons

Issue 10134056: Refactor the process of choosing validators. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: tweaks for win64 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/service_runtime/build.scons
diff --git a/src/trusted/service_runtime/build.scons b/src/trusted/service_runtime/build.scons
index bdc1c942a79670755e12549b8d262ca0af70dc44..b46883c0aa5fa0caeb749c5bafb22b4c7d395f48 100644
--- a/src/trusted/service_runtime/build.scons
+++ b/src/trusted/service_runtime/build.scons
@@ -747,8 +747,10 @@ if env.Bit('target_x86'):
env.File(arch_testdata_dir + '/hello_world.nexe'),
stdout_golden = env.File('testdata/hello_world.stdout'),
stderr_golden = env.File('testdata/dfa_validator_hello.stderr'),
- filter_regex = '"^(Hello, World!)$|DANGER"',
+ filter_regex = '"^(Hello, World!)$' + '|' +
+ '^[[][^]]*[]] (DANGER! USING THE EXPERIMENTAL DFA VALIDATOR!)$"',
osenv='NACL_DANGEROUS_USE_DFA_VALIDATOR=1',
+ filter_group_only = 'true',
Mark Seaborn 2012/06/21 18:42:01 Nit: put this immediately after the "filter_regex"
pasko-google - do not use 2012/06/22 10:11:27 Ok a little more goodness. Done.
)
env.AddNodeToTestSuite(node, ['medium_tests', 'validator_tests'],
'run_dfa_validator_hello_world_test')

Powered by Google App Engine
This is Rietveld 408576698