Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Side by Side Diff: src/trusted/validator/build.scons

Issue 10134056: Refactor the process of choosing validators. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: rebased, added a todo for NaClCopyCode Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # -*- python -*- 1 # -*- python -*-
2 # Copyright (c) 2011 The Native Client Authors. All rights reserved. 2 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 6
7 import os 7 import os
8 import sys 8 import sys
9 Import('env') 9 Import('env')
10 10
11 # 11 #
12 # Build common file handling utilities for all validators. 12 # Build common file handling utilities for all validators.
13 # 13 #
14 lib_env = env.Clone(); 14 lib_env = env.Clone();
15 lib_env.Append(CPPPATH=['${TARGET_ROOT}']) 15 lib_env.Append(CPPPATH=['${TARGET_ROOT}'])
16 lib_env.ComponentLibrary(lib_env.NaClTargetArchSuffix('ncfileutils'), 16 lib_env.ComponentLibrary(lib_env.NaClTargetArchSuffix('ncfileutils'),
17 ['ncfileutil.c']) 17 ['ncfileutil.c'])
18 18
19 lib_env.ComponentLibrary('validators', ['validator_init.c'])
19 20
20 if env.Bit('target_x86'): 21 if env.Bit('target_x86'):
21 # TODO(ncbray) support ARM. This will require making validation caching safe 22 # TODO(ncbray) support ARM. This will require making validation caching safe
22 # for ARM and embedding ARM binary chunks in the test that can trigger various 23 # for ARM and embedding ARM binary chunks in the test that can trigger various
23 # validation scenarios. 24 # validation scenarios.
24 gtest_env = env.MakeGTestEnv() 25 gtest_env = env.MakeGTestEnv()
25 validator_libs = [gtest_env.NaClTargetArchSuffix('ncvalidate')] 26 validator_libs = ['validators', gtest_env.NaClTargetArchSuffix('ncvalidate')]
26 27
27 validation_cache_test_exe = gtest_env.ComponentProgram( 28 validation_cache_test_exe = gtest_env.ComponentProgram(
28 'validation_cache_test', 29 'validation_cache_test',
29 ['validation_cache_test.cc'], 30 ['validation_cache_test.cc'],
30 EXTRA_LIBS=validator_libs) 31 EXTRA_LIBS=validator_libs)
31 32
32 node = gtest_env.CommandTest( 33 node = gtest_env.CommandTest(
33 'validation_cache_test.out', 34 'validation_cache_test.out',
34 command=[validation_cache_test_exe]) 35 command=[validation_cache_test_exe])
35 36
36 env.AddNodeToTestSuite(node, ['small_tests', 'validator_tests'], 37 env.AddNodeToTestSuite(node, ['small_tests', 'validator_tests'],
37 'run_validation_cache_test') 38 'run_validation_cache_test')
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698