Refactor the process of choosing validators.

src/trusted/service_runtime/service_runtime.gyp

 # -*- gyp -*-
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'conditions': [
       ['OS=="linux"', {
         'syscall_handler': [
@@ skipping 187 matching lines @@
         }],
       ],
    },
   'targets': [
     {
       'target_name': 'sel',
       'type': 'static_library',
       'variables': {
         'target_base': 'sel',
       },
+      'sources': [
+          '<(DEPTH)/native_client/src/trusted/validator/validator_init.c',

[Nick Bray, 2012/05/22 23:46:31]

This should be added to the 'target_base=="sel"' declaration - where all the
other sources are.  Note there are 'sel' and 'sel64' targets where this source
list gets injected into.  because you put it here, the sel64 version didn't get
the source file and you papered over the problem by also adding it to the 64-bit
validator's gyp file.  You should be able to remove that change after cleaning
up this file?

Nit: _init may be the wrong file name - _interface?  I don't have a very good
suggestion, but I feel it's not quite right.

Indentation is wrong.

[pasko-google - do not use, 2012/05/23 14:28:11]

Thank you for this! Seriously, great suggestion! I tried to put this source in
different places and was completely frustrated :)

Things like this:
'target_conditions': [['target_base=="sel"',
... look just sooo cute for a GYP newbie. Freaks me out.

Done.
Same thoughts here, maybe validator_selector?
Done.

+      ],
       'dependencies': [
         'env_cleanser',
         'nacl_error_code',
         '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio',
         '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform',
         '<(DEPTH)/native_client/src/shared/srpc/srpc.gyp:nonnacl_srpc',
         '<(DEPTH)/native_client/src/trusted/debug_stub/debug_stub.gyp:debug_stub',
         '<(DEPTH)/native_client/src/trusted/desc/desc.gyp:nrd_xfer',
         '<(DEPTH)/native_client/src/trusted/fault_injection/fault_injection.gyp:nacl_fault_inject',
         '<(DEPTH)/native_client/src/trusted/gdb_rsp/gdb_rsp.gyp:gdb_rsp',
@@ skipping 189 matching lines @@
             '<(DEPTH)/native_client/src/trusted/platform_qualify/platform_qualify.gyp:platform_qual_lib64',
           ],
           'sources': [
             'sel_main_chrome_test.c',
           ],
         },
       ],
     }],
   ]
 }