Refactor the process of choosing validators.

src/trusted/validator_arm/ncvalidate.cc

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "native_client/src/trusted/validator_arm/ncvalidate.h"
 
 
 #include <vector>
@@ skipping 67 matching lines @@
   UNREFERENCED_PARAMETER(cache);
 
   if (stubout_mode)
     return NaClValidationFailedNotImplemented;
   if (readonly_text)
     return NaClValidationFailedNotImplemented;
 
   return ((0 == NCValidateSegment(data, guest_addr, size))
            ? NaClValidationSucceeded : NaClValidationFailed);
 }
-
-NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCodeReplacement, arm, 32)

[Nick Bray, 2012/04/25 20:57:42]

See previous comments, probably want to keep.

[pasko-google - do not use, 2012/04/26 15:17:01]

This would lead us to creating quite a few stubs, keeping these stubs
platform-newtral saves some space. And then they could be moved to some utility
file.

Or we could have platform-newtral ValidatorRunner(nap->some_func) that would
return NotImplemented iff nap->some_func == NULL else run the function

[Nick Bray, 2012/04/27 00:41:30]

Yeah, I was thinking of putting a NULL check in sel_ldr, but I think the stub
function is cleaner.  (I think this is a pattern.  Active Sentinel?  Can't find
a reference to it.)  I do think having each validator declare its own stubs will
be cleaner in the long run, because of build/link mess, but this isn't a big
issue for me - your call.

-    (uintptr_t guest_addr,
-     uint8_t *data_old,
-     uint8_t *data_new,
-     size_t size,
-     const NaClCPUFeaturesArm *cpu_features) {
-  UNREFERENCED_PARAMETER(guest_addr);
-  UNREFERENCED_PARAMETER(data_old);
-  UNREFERENCED_PARAMETER(data_new);
-  UNREFERENCED_PARAMETER(size);
-  UNREFERENCED_PARAMETER(cpu_features);
-  return NaClValidationFailedNotImplemented;
-}
-
-NaClValidationStatus NACL_SUBARCH_NAME(ApplyValidatorCopy, arm, 32)
-    (uintptr_t guest_addr,
-     uint8_t *data_old,
-     uint8_t *data_new,
-     size_t size,
-     const NaClCPUFeaturesArm *cpu_features) {
-  UNREFERENCED_PARAMETER(guest_addr);
-  UNREFERENCED_PARAMETER(data_old);
-  UNREFERENCED_PARAMETER(data_new);
-  UNREFERENCED_PARAMETER(size);
-  UNREFERENCED_PARAMETER(cpu_features);
-  return NaClValidationFailedNotImplemented;
-}
-
 EXTERN_C_END