Issue 10134043: Used test util to crash the browser, and restart the browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10134043: Used test util to crash the browser, and restart the browser (Closed)

Created:
8 years, 8 months ago by tturchetto

Modified:
8 years, 8 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Used test util to crash the browser, and restart the browser Modified browser crash test. Used CrashBrowser from test_utils and RestartBrowser BUG=none TEST=This is a test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133785

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed testCloseAllTabs #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/test/functional/chromeos_browser.py	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

https://chromiumcodereview.appspot.com/10134043/diff/1/chrome/test/functional/chromeos_browser.py File chrome/test/functional/chromeos_browser.py (right): https://chromiumcodereview.appspot.com/10134043/diff/1/chrome/test/functional/chromeos_browser.py#newcode13 chrome/test/functional/chromeos_browser.py:13: def testCloseAllTabs(self): did you forget to sync?

8 years, 8 months ago (2012-04-24 22:01:45 UTC) #2

tturchetto

8 years, 8 months ago (2012-04-24 22:09:50 UTC) #3

LGTM

Expand Messages | Collapse Messages