plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/EvaluateHack.java - Issue 10134042: Update WIP interfaces and fix spell error in typedef template

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/EvaluateHack.java

Issue 10134042: Update WIP interfaces and fix spell error in typedef template (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.sdk.wipbackend.dev/src-wip-generated/org/chromium/sdk/internal/wip/protocol/output/runtime/EvaluateParams.java ('k') | plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/EvaluateHack.java

diff --git a/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/EvaluateHack.java b/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/EvaluateHack.java

index 13607fa572457caaccddd69b20a1c3c6dc8ce7c4..e7975c0dd3e6cd31d6548edf95740cfe72e96697 100644

--- a/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/EvaluateHack.java

+++ b/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/EvaluateHack.java

@@ -205,7 +205,7 @@ public class EvaluateHack {

arguments.add(new CallArgumentParam(null, objectId));

}

- return new CallFunctionOnParams(thisObjectIdFinal, functionText, arguments, true);

+ return new CallFunctionOnParams(thisObjectIdFinal, functionText, arguments, null, true);

}

@Override

@@ -277,7 +277,7 @@ public class EvaluateHack {

@Override

public WipParamsWithResponse<CallFunctionOnData> getParams() {

String functionText = "function() { return String(this.message); }";

- return new CallFunctionOnParams(remoteObjectValue.objectId(), functionText, null, true);

+ return new CallFunctionOnParams(remoteObjectValue.objectId(), functionText, null, null, true);

}

@Override