Set svn:executable bit on scripts that are executable.

Set svn:executable bit on scripts that are executable.

Add a PRESUBMIT.py to run checkperms.py when it is modified and to run pylint on it.

R=thestig@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133835

[Lei Zhang, 2012-04-21 02:55:09]

I'm not sure if the __init__.py scripts have to executable. Nobody's going to
run them directly.

[Lei Zhang, 2012-04-21 02:56:42]

https://chromiumcodereview.appspot.com/10134019/diff/2002/tools/checkperms/py...
File tools/checkperms/pylintrc (right):

https://chromiumcodereview.appspot.com/10134019/diff/2002/tools/checkperms/py...
tools/checkperms/pylintrc:1: [MASTER]
Is this file copied from elsewhere? Is there a way to share one copy rather than
having multiple copies? E.g. there's several other Python scripts in
tools/check*

[Marc-Antoine Ruel (Google), 2012-04-21 12:50:25]

Note that the end goal is to properly fix all the current scripts, and then
update checkperms.py to be *much* stricter,

http://codereview.chromium.org/10088002/diff/1/tools/checkperms/checkperms.py

Do not review the above yet, as I want to fix the scripts first.

https://chromiumcodereview.appspot.com/10134019/diff/2002/tools/checkperms/py...
File tools/checkperms/pylintrc (right):

https://chromiumcodereview.appspot.com/10134019/diff/2002/tools/checkperms/py...
tools/checkperms/pylintrc:1: [MASTER]
On 2012/04/21 02:56:42, Lei Zhang wrote:
> Is this file copied from elsewhere? Is there a way to share one copy rather
than
> having multiple copies? E.g. there's several other Python scripts in
> tools/check*

Actually, I just found the --rcfile flag. Note sure why I didn't use it in the
first place. The canned presubmit check doesn't support that yet, so I'll have
to add the default one to depot_tools and then retro fit it everywhere.

So either:
- I remove the pylintrc file and the pylint presubmit check from this CL, fix
depot_tools and then add the check back here
 or
- Leave this CL as-is, fix depot_tools, then remove this file.

[Lei Zhang, 2012-04-24 03:02:56]

On 2012/04/21 12:50:25, Marc-Antoine Ruel (Google) wrote:
> Note that the end goal is to properly fix all the current scripts, and then
> update checkperms.py to be *much* stricter,
> 
> http://codereview.chromium.org/10088002/diff/1/tools/checkperms/checkperms.py
> 
> Do not review the above yet, as I want to fix the scripts first.
> 
>
https://chromiumcodereview.appspot.com/10134019/diff/2002/tools/checkperms/py...
> File tools/checkperms/pylintrc (right):
> 
>
https://chromiumcodereview.appspot.com/10134019/diff/2002/tools/checkperms/py...
> tools/checkperms/pylintrc:1: [MASTER]
> On 2012/04/21 02:56:42, Lei Zhang wrote:
> > Is this file copied from elsewhere? Is there a way to share one copy rather
> than
> > having multiple copies? E.g. there's several other Python scripts in
> > tools/check*
> 
> Actually, I just found the --rcfile flag. Note sure why I didn't use it in the
> first place. The canned presubmit check doesn't support that yet, so I'll have
> to add the default one to depot_tools and then retro fit it everywhere.
> 
> So either:
> - I remove the pylintrc file and the pylint presubmit check from this CL, fix
> depot_tools and then add the check back here
>  or
> - Leave this CL as-is, fix depot_tools, then remove this file.

Which ever is more convenient for you.

[M-A Ruel, 2012-04-24 15:37:38]

On 2012/04/24 03:02:56, Lei Zhang wrote:
> Which ever is more convenient for you.

Removed pylintrc but now dependent on
https://chromiumcodereview.appspot.com/10199016/

[Lei Zhang, 2012-04-24 17:38:35]

lgtm

[commit-bot: I haz the power, 2012-04-24 23:36:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10134019/12001

[commit-bot: I haz the power, 2012-04-25 01:25:41]

Change committed as 133835