chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js - Issue 10134008: Add bind(), recvFrom(), sendTo() for UDP socket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

Issue 10134008: Add bind(), recvFrom(), sendTo() for UDP socket. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reenable api tests Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/socket/udp_socket_unittest.cc ('K') | « chrome/common/extensions/api/experimental.socket.idl ('k') | chrome/test/data/extensions/api_test/socket/api/background.js » ('j') | net/udp/udp_socket_libevent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js b/chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

index 40011b249d2454b2d92a8775b65ad9a3d3742205..80f016b68f6bb99b91dcab1097ce2cf2989c327e 100644

--- a/chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

@@ -16,10 +16,10 @@

apiFunctions.setHandleRequest('create', function() {

var args = arguments;

- if (args.length > 3 && args[3] && args[3].onEvent) {

+ if (args.length > 1 && args[1] && args[1].onEvent) {

var id = GetNextSocketEventId();

- args[3].srcId = id;

- chromeHidden.socket.handlers[id] = args[3].onEvent;

+ args[1].srcId = id;

+ chromeHidden.socket.handlers[id] = args[1].onEvent;

// Keep the page alive until the event finishes.

// Balanced in eventHandler.