Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4730)

Unified Diff: chrome/browser/extensions/api/socket/tcp_socket.h

Issue 10134008: Add bind(), recvFrom(), sendTo() for UDP socket. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reenable api tests Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/tcp_socket.h
diff --git a/chrome/browser/extensions/api/socket/tcp_socket.h b/chrome/browser/extensions/api/socket/tcp_socket.h
index 051abf45ea2c9c04c12cd5eae84ae7361a2ab53b..fba9580121b62b8333c13d62258490d97d4c9cbc 100644
--- a/chrome/browser/extensions/api/socket/tcp_socket.h
+++ b/chrome/browser/extensions/api/socket/tcp_socket.h
@@ -24,28 +24,34 @@ class APIResourceEventNotifier;
class TCPSocket : public Socket {
public:
- TCPSocket(const std::string& address, int port,
- APIResourceEventNotifier* event_notifier);
+ explicit TCPSocket(APIResourceEventNotifier* event_notifier);
virtual ~TCPSocket();
virtual bool IsValid() OVERRIDE;
- virtual int Connect() OVERRIDE;
+ virtual int Connect(const std::string& address, int port) OVERRIDE;
virtual void Disconnect() OVERRIDE;
+ virtual int Bind(const std::string& address, int port) OVERRIDE;
+ virtual int Read(scoped_refptr<net::IOBuffer> io_buffer,
+ int io_buffer_size) OVERRIDE;
+ virtual int Write(scoped_refptr<net::IOBuffer> io_buffer,
+ int bytes) OVERRIDE;
+ virtual int RecvFrom(scoped_refptr<net::IOBuffer> io_buffer,
+ int io_buffer_size,
+ net::IPEndPoint *address) OVERRIDE;
+ virtual int SendTo(scoped_refptr<net::IOBuffer> io_buffer,
+ int byte_count,
+ const std::string& address,
+ int port) OVERRIDE;
virtual void OnConnect(int result);
static TCPSocket* CreateSocketForTesting(
net::TCPClientSocket* tcp_client_socket,
- const std::string& address, int port,
APIResourceEventNotifier* event_notifier);
- protected:
- virtual net::Socket* socket() OVERRIDE;
-
private:
TCPSocket(net::TCPClientSocket* tcp_client_socket,
- const std::string& address, int port,
APIResourceEventNotifier* event_notifier);
scoped_ptr<net::TCPClientSocket> socket_;

Powered by Google App Engine
This is Rietveld 408576698