Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 10134006: Disabling stepping into callback function of String.replace. (Closed)

Created:
8 years, 8 months ago by Yang
Modified:
8 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Disabling stepping into callback function of String.replace. This is being done due to performance concerns. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -97 lines) Patch
M src/string.js View 3 chunks +15 lines, -48 lines 0 comments Download
M test/mjsunit/debug-stepin-builtin-callback.js View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
PTAL. This reverts part of r11399.
8 years, 8 months ago (2012-04-20 12:28:58 UTC) #1
Yang
PTAL.
8 years, 8 months ago (2012-04-20 12:29:15 UTC) #2
Michael Starzinger
8 years, 8 months ago (2012-04-20 14:03:27 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698