Show names for the strong roots in heap snapshot.

Show names for the strong roots in heap snapshot.

Committed: https://code.google.com/p/v8/source/detail?r=11392

[mnaganov (inactive), 2012-04-19 13:52:29]

https://chromiumcodereview.appspot.com/10128006/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/10128006/diff/1/src/profile-generator....
src/profile-generator.h:1028: const char* GetGcSubrootName(Object* object);
If it deals only with strong roots, perhaps call it 'GetStrongGcSubrootName'?

https://chromiumcodereview.appspot.com/10128006/diff/1/src/profile-generator....
src/profile-generator.h:1043: HashMap gc_subroot_names_;
Why are you using a generic HashMap? HeapObjectsSet can associate heap objects
with tags.

https://chromiumcodereview.appspot.com/10128006/diff/1/test/cctest/test-heap-...
File test/cctest/test-heap-profiler.cc (right):

https://chromiumcodereview.appspot.com/10128006/diff/1/test/cctest/test-heap-...
test/cctest/test-heap-profiler.cc:13: #include <ctype.h>
System headers must go before project headers:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Names_...

[alexeif, 2012-04-19 15:27:41]

Thanks for your comments. PTAL.

https://chromiumcodereview.appspot.com/10128006/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/10128006/diff/1/src/profile-generator....
src/profile-generator.h:1028: const char* GetGcSubrootName(Object* object);
On 2012/04/19 13:52:29, Mikhail Naganov (Chromium) wrote:
> If it deals only with strong roots, perhaps call it 'GetStrongGcSubrootName'?

Done.

https://chromiumcodereview.appspot.com/10128006/diff/1/src/profile-generator....
src/profile-generator.h:1043: HashMap gc_subroot_names_;
On 2012/04/19 13:52:29, Mikhail Naganov (Chromium) wrote:
> Why are you using a generic HashMap? HeapObjectsSet can associate heap objects
> with tags.

Done.

https://chromiumcodereview.appspot.com/10128006/diff/1/test/cctest/test-heap-...
File test/cctest/test-heap-profiler.cc (right):

https://chromiumcodereview.appspot.com/10128006/diff/1/test/cctest/test-heap-...
test/cctest/test-heap-profiler.cc:13: #include <ctype.h>
On 2012/04/19 13:52:29, Mikhail Naganov (Chromium) wrote:
> System headers must go before project headers:
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Names_...

Done.

[mnaganov (inactive), 2012-04-19 15:50:39]

lgtm