Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10127011: A generative consutructor on an interface can default to a factory constructor. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/builder.dart
===================================================================
--- lib/compiler/implementation/ssa/builder.dart (revision 6748)
+++ lib/compiler/implementation/ssa/builder.dart (working copy)
@@ -2153,13 +2153,12 @@
}
HType type = HType.UNKNOWN;
Element originalElement = elements[node];
- if (originalElement.isGenerativeConstructor()) {
- ClassElement cls = originalElement.enclosingElement;
- if (cls === compiler.listClass) {
- type = HType.MUTABLE_ARRAY;
- } else {
- type = new HNonPrimitiveType(cls.type);
- }
+ if (originalElement.isGenerativeConstructor()
+ && originalElement.enclosingElement === compiler.listClass) {
+ type = HType.MUTABLE_ARRAY;
+ } else if (element.isGenerativeConstructor()) {
+ ClassElement cls = element.enclosingElement;
+ type = new HNonPrimitiveType(cls.type);
}
push(new HInvokeStatic(selector, inputs, type));
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698