Support passing an environment variable map to child processes.

runtime/bin/process_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _ProcessStartStatus {
   int _errorCode;  // Set to OS error code if process start failed.
   String _errorMessage;  // Set to OS error message if process start failed.
 }
 
 
@@ skipping 50 matching lines @@
     }
 
     if (options !== null && options.workingDirectory !== null) {
       _workingDirectory = options.workingDirectory;
       if (_workingDirectory is !String) {
         throw new IllegalArgumentException(
             "WorkingDirectory is not a String: $_workingDirectory");
       }
     }
 
+    if (options !== null && options.environment !== null) {
+      var env = options.environment;
+      if (env is !Map) {
+        throw new IllegalArgumentException("Environment is not a map: $env");
+      }
+      _environment = [];
+      env.forEach((key, value) {
+        if (key is !String || value is !String) {

[Søren Gjesse, 2012/04/19 12:45:55]

Maybe we should allow any type on value and just rely on tpString. E.g. numbers
makes sense.

[Søren Gjesse, 2012/04/19 12:45:55]

Check that the key does not contain illegal charcters e.g. =.

[Søren Gjesse, 2012/04/19 12:45:55]

For both key and value.toString() is there any charset restriction?

[Mads Ager (google), 2012/04/20 12:24:51]

I would like to start out requiring this to be a Map<String, String>. toString
is not guaranteed to return a string so these checks are needed anyway. We can
of course perform toString and then check the result but I think it is fair to
force the programmer to make environment-variable values strings.

[Mads Ager (google), 2012/04/20 12:24:51]

An early check for that would make sense, thanks. Added.

[Mads Ager (google), 2012/04/20 12:24:51]

Yes, at this point if you go out of ASCII range the Windows implementation will
not like that. I will add a note on that. The VM does not behave nicely in this
situation. It does not return an error when Dart_NewString() is passed invalid
utf8 data. I have filed issue 2663 on that. When that is fixed it should fail
somewhat gracefully.

+          throw new IllegalArgumentException(
+              "Environment key or value is not a string: ($key, $value)");
+        }
+        _environment.add('$key=$value');
+      });
+    }
+
     _in = new _Socket._internalReadOnly();  // stdout coming from process.
     _out = new _Socket._internalWriteOnly();  // stdin going to process.
     _err = new _Socket._internalReadOnly();  // stderr coming from process.
     _exitHandler = new _Socket._internalReadOnly();
     _closed = false;
     _killed = false;
     _started = false;
     _onExit = null;
     // TODO(ager): Make the actual process starting really async instead of
     // simulating it with a timer.
@@ skipping 51 matching lines @@
             (bytes[offset + 1] << 8) +
             (bytes[offset + 2] << 16) +
             (bytes[offset + 3] << 24));
   }
 
   void start() {
     var status = new _ProcessStartStatus();
     bool success = _start(_path,
                           _arguments,
                           _workingDirectory,
+                          _environment,
                           _in,
                           _out,
                           _err,
                           _exitHandler,
                           status);
     if (!success) {
       close();
       if (_onError !== null) {
         _onError(new ProcessException(status._errorMessage, status._errorCode));
         return;
@@ skipping 33 matching lines @@
     };
 
     if (_onStart !== null) {
       _onStart();
     }
   }
 
   bool _start(String path,
               List<String> arguments,
               String workingDirectory,
+              List<String> environment,
               Socket input,
               Socket output,
               Socket error,
               Socket exitHandler,
               _ProcessStartStatus status) native "Process_Start";
 
   InputStream get stdout() {
     if (_closed) {
       throw new ProcessException("Process closed");
     }
@@ skipping 62 matching lines @@
     _onError = callback;
   }
 
   void set onStart(void callback()) {
     _onStart = callback;
   }
 
   String _path;
   ObjectArray<String> _arguments;
   String _workingDirectory;
+  List<String> _environment;
   // Private methods of _Socket are used by _in, _out, and _err.
   _Socket _in;
   _Socket _out;
   _Socket _err;
   Socket _exitHandler;
   int _pid;
   bool _closed;
   bool _killed;
   bool _started;
   Function _onExit;
@@ skipping 109 matching lines @@
   void close() => _process.close();
 
   Process _process;
   Function _callback;
   StringBuffer _stdoutBuffer;
   StringBuffer _stderrBuffer;
   int _exitCode;
   bool _stdoutClosed = false;
   bool _stderrClosed = false;
 }