Remove suppression code for VM crash! Celebrate!

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 239 matching lines @@
       stdout, stderr, time);
   }
 
   String get result() =>
       hasCrashed ? CRASH : (hasTimedOut ? TIMEOUT : (hasFailed ? FAIL : PASS));
 
   bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
 
   bool get hasCrashed() {
     if (Platform.operatingSystem() == 'windows') {
-      if (exitCode != 0) {
-        // Suppress some flaky errors that crash the VM.
-        // TODO(sigmund,efortuna): remove this when bug 2124 gets fixed.
-        for (String line in testCase.output.stdout) {
-          if (line.startsWith('Kind:')) {
-            if (!alreadyPrintedWarning) {
-              print("WARNING: VM crashed: $line, exit code: $exitCode. "
-                    " This is a fake pass!!");
-              alreadyPrintedWarning = true;
-            }
-            return false;
-          }
-        }
-      }
-
       // The VM uses std::abort to terminate on asserts.
       // std::abort terminates with exit code 3 on Windows.
       if (exitCode == 3) {
         return !timedOut;
       }
       return (!timedOut && (exitCode < 0) && ((0x3FFFFF00 & exitCode) == 0));
     }
     // The Java dartc runner exits with code 253 in case of unhandled
     // exceptions.
     return (!timedOut && ((exitCode < 0) || (exitCode == 253)));
   }
 
   bool get hasTimedOut() => timedOut;
 
   bool get didFail() {
     return (exitCode != 0 && !hasCrashed);
   }
 
   // Reverse result of a negative test.
-  bool get hasFailed() {
-    // TODO(efortuna): This is a total hack to keep our buildbots (more) green
-    // while the VM team solves Issue 2124. Remove when issue is fixed.
-    if (Platform.operatingSystem() == 'windows' && (exitCode == 253 ||
-        exitCode == 3)) {
-      for (String line in testCase.output.stdout) {
-        if (line.startsWith('VM exited with signal 1073741819') ||
-            line.startsWith('Kind:')) {
-          if (!alreadyPrintedWarning) {
-            print("WARNING: VM crashed: $line This is a fake pass!!");
-            alreadyPrintedWarning = true;
-          }
-          return testCase.expectedOutcomes.iterator().next() == FAIL;
-        }
-      }
-    }
-    return (testCase.isNegative ? !didFail : didFail);
-  }
+  bool get hasFailed() => testCase.isNegative ? !didFail : didFail;
 
 }
 
 class BrowserTestOutputImpl extends TestOutputImpl {
   BrowserTestOutputImpl(testCase, exitCode, timedOut, stdout, stderr, time) :
     super(testCase, exitCode, timedOut, stdout, stderr, time);
 
   bool get didFail() {
     // Browser case:
     // If the browser test failed, it may have been because DumpRenderTree
@@ skipping 842 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }