Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 10123011: Finish refactoring done for ia32 for the other platforms. (Closed)

Created:
8 years, 8 months ago by fschneider
Modified:
8 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Finish refactoring done for ia32 for the other platforms. Make non-templatized versions of LIR printing functions. This avoid duplicating the code for each template instance. BUG=v8:1803 Committed: https://code.google.com/p/v8/source/detail?r=11394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -45 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
It's a small reduction in d8 binary size ~7K. I have no idea why I ...
8 years, 8 months ago (2012-04-19 14:45:45 UTC) #1
Michael Starzinger
8 years, 8 months ago (2012-04-19 15:12:56 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698