Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: tests/language/src/TempManglingTest.dart

Issue 10123009: Fix mangling of local variables when their name conflict with Dart2JS's temporaries. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/src/TempManglingTest.dart
===================================================================
--- tests/language/src/TempManglingTest.dart (revision 0)
+++ tests/language/src/TempManglingTest.dart (revision 0)
@@ -0,0 +1,31 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+main() {
+ testOne();
+ testTwo();
+}
+
+testOne() {
+ // Dart2JS uses t[0-9]* to declare temporaries, so a local variable
+ // with that pattern can conflict with them.
+ var t0 = new List();
+ // By using 'is' check, we make sure 't0.length' does not become
+ // generate at use site.
+ Expect.isTrue(t0.length is int);
+ Expect.isTrue(t0 is List);
+}
+
+testTwo() {
+ var x = new List();
+ var x_0 = new List();
+ {
+ // This used to introduce x_0.
+ var x = new Set();
+ Expect.equals(0, x.length);
+ Expect.isTrue(x.isEmpty());
+ }
+ Expect.isTrue(x is List);
+ Expect.isTrue(x_0 is List);
+}
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698