Issue 10123007: Optimize ~~(expr) in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10123007: Optimize ~~(expr) in optimized code. (Closed)

Created:
8 years, 8 months ago by fschneider

Modified:
8 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Optimize ~~(expr) in optimized code. ~~ is commonly used to truncate a value to int32 (ToInt32). This change avoid actually emitting the bitwise operations, and just truncates the subexpression of ~~. BUG=v8:2037 TEST=test/mjsunit/compiler/optimize-bitnot.js Committed: https://code.google.com/p/v8/source/detail?r=11390

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -0 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/mjsunit/compiler/optimize-bitnot.js	View	1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages