Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: media/filters/chunk_demuxer.cc

Issue 10123005: Revert 132965 - this change seems to break media_unittests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/chunk_demuxer.h ('k') | media/filters/chunk_demuxer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/chunk_demuxer.cc
===================================================================
--- media/filters/chunk_demuxer.cc (revision 132968)
+++ media/filters/chunk_demuxer.cc (working copy)
@@ -15,9 +15,6 @@
namespace media {
-// TODO(acolwell): Remove this when fixing http://crbug.com/122909 .
-const char* kDefaultSourceType = "video/webm; codecs=\"vp8, vorbis\"";
-
// Create an "end of stream" buffer.
static Buffer* CreateEOSBuffer() {
return new DataBuffer(0);
@@ -458,40 +455,10 @@
ChangeState_Locked(INITIALIZED);
}
-ChunkDemuxer::Status ChunkDemuxer::AddId(const std::string& id,
- const std::string& type) {
- // TODO(acolwell): Proper mimetype decoding and support for more than one ID
- // will be added as part of http://crbug.com/122909
- if (type != kDefaultSourceType)
- return kNotSupported;
+bool ChunkDemuxer::AppendData(const uint8* data, size_t length) {
+ DVLOG(1) << "AppendData(" << length << ")";
- if (!source_id_.empty())
- return kReachedIdLimit;
-
- source_id_ = id;
- return kOk;
-}
-
-bool ChunkDemuxer::RemoveId(const std::string& id) {
- DCHECK(!source_id_.empty());
- DCHECK_EQ(source_id_, id);
- source_id_ = "";
- return true;
-}
-
-bool ChunkDemuxer::AppendData(const std::string& id,
- const uint8* data,
- size_t length) {
- DVLOG(1) << "AppendData(" << id << ", " << length << ")";
-
- // TODO(acolwell): Remove when http://webk.it/83788 fix lands.
- if (source_id_.empty())
- AddId(id, kDefaultSourceType);
-
- DCHECK(!source_id_.empty());
- DCHECK_EQ(source_id_, id);
-
- if (id.empty() || !data || length == 0u)
+ if (!data || length == 0u)
return false;
int64 buffered_bytes = 0;
« no previous file with comments | « media/filters/chunk_demuxer.h ('k') | media/filters/chunk_demuxer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698