Issue 10121005: Add dbus::ObjectProxy::CallMethodWithErrorCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10121005: Add dbus::ObjectProxy::CallMethodWithErrorCallback (Closed)

Created:
8 years, 8 months ago by hashimoto

Modified:
8 years, 8 months ago

Reviewers:
keybuk, satorux1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add dbus::ObjectProxy::CallMethodWithErrorCallback Add CallMethodWithErrorCallback Add EndToEndAsyncTest.BrokenBus Fix leak in StartAsyncMethodCall BUG=chromium-os:27899 TEST=dbus_unittests --gtest_filter="EndToEndAsyncTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133140

Patch Set 1 : _ #

Patch Set 2 : Fix comment #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+227 lines, -11 lines)			Patch
M	dbus/end_to_end_async_unittest.cc	View	1	9 chunks	+155 lines, -0 lines	0 comments	Download
M	dbus/object_proxy.h	View		6 chunks	+34 lines, -0 lines	0 comments	Download
M	dbus/object_proxy.cc	View		10 chunks	+38 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10121005/2001

8 years, 8 months ago (2012-04-19 23:42:41 UTC) #4

commit-bot: I haz the power

8 years, 8 months ago (2012-04-20 02:55:18 UTC) #5

Try job failure for 10121005-2001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages