Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: lib/compiler/implementation/ssa/types.dart

Issue 10119010: Start propagating non-primitive types in the backend, and fold instructions that know about the typ… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/types.dart
===================================================================
--- lib/compiler/implementation/ssa/types.dart (revision 6686)
+++ lib/compiler/implementation/ssa/types.dart (working copy)
@@ -127,6 +127,9 @@
HType desiredType = computeDesiredType(instruction);
// If the desired type is conflicting just return the computed type.
if (desiredType.isConflicting()) return newType;
+ // TODO(ngeoffray): Allow speculative optimizations on
+ // non-primitive types?
floitsch 2012/04/18 19:18:48 Why not. But that would require adding a isNonPrim
+ if (desiredType.isNonPrimitive()) return newType;
return newType.combine(desiredType);
}
}

Powered by Google App Engine
This is Rietveld 408576698