Move custom to dart conversion logic to IDLTypeInfo implementations.

lib/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 765 matching lines @@
       return '%s::%s' % (idl_node.ext_attrs['ImplementedBy'], function_name)
     return '%s%s' % (self._interface_type_info.receiver(), function_name)
 
   def _GenerateWebCoreInvocation(self, function_expression, arguments,
       idl_return_type, attributes, raises_dom_exceptions):
     invocation_template = '        $FUNCTION_CALL;\n'
     if idl_return_type != 'void':
       return_type_info = GetIDLTypeInfo(idl_return_type)
       self._cpp_impl_includes |= set(return_type_info.to_dart_includes())
 
-      # Generate C++ cast based on idl return type.
-      conversion_cast = return_type_info.conversion_cast('$FUNCTION_CALL')
-      if isinstance(return_type_info, SVGTearOffIDLTypeInfo):
-        svg_primitive_types = ['SVGAngle', 'SVGLength', 'SVGMatrix',
-            'SVGNumber', 'SVGPoint', 'SVGRect', 'SVGTransform']
-        conversion_cast = '%s::create($FUNCTION_CALL)'
-        if self._interface.id.startswith('SVGAnimated'):
-          conversion_cast = 'static_cast<%s*>($FUNCTION_CALL)'
-        elif return_type_info.idl_type() == 'SVGStringList':
-          conversion_cast = '%s::create(receiver, $FUNCTION_CALL)'
-        elif self._interface.id.endswith('List'):
-          conversion_cast = 'static_cast<%s*>($FUNCTION_CALL.get())'
-        elif return_type_info.idl_type() in svg_primitive_types:
-          conversion_cast = '%s::create($FUNCTION_CALL)'
-        else:
-          conversion_cast = 'static_cast<%s*>($FUNCTION_CALL)'
-        conversion_cast = conversion_cast % return_type_info.native_type()
-
       # Generate to Dart conversion of C++ value.
-      conversion_arguments = [conversion_cast]
-      if (return_type_info.idl_type() in ['DOMString', 'AtomicString'] and
-          'TreatReturnedNullStringAs' in attributes):
-        conversion_arguments.append('ConvertDefaultToNull')
-
+      to_dart_conversion = return_type_info.to_dart_conversion('$FUNCTION_CALL', self._interface.id, attributes)
       invocation_template = emitter.Format(
-          '        Dart_Handle returnValue = toDartValue($ARGUMENTS);\n'
+          '        Dart_Handle returnValue = $TO_DART_CONVERSION;\n'
           '        if (returnValue)\n'
           '            Dart_SetReturnValue(args, returnValue);\n',
-          ARGUMENTS=', '.join(conversion_arguments))
+          TO_DART_CONVERSION=to_dart_conversion)
 
     if raises_dom_exceptions:
       # Add 'ec' argument to WebCore invocation and convert DOM exception to Dart exception.
       arguments.append('ec')
       invocation_template = emitter.Format(
           '        ExceptionCode ec = 0;\n'
           '$INVOCATION'
           '        if (UNLIKELY(ec)) {\n'
           '            exception = DartDOMWrapper::exceptionCodeToDartException(ec);\n'
           '            goto fail;\n'
@@ skipping 18 matching lines @@
 def _InstanceOfNode(database, interface):
   if interface.id == 'Node':
     return True
   for parent in interface.parents:
     if not database.HasInterface(parent.type.id):
       continue
     parent_interface = database.GetInterface(parent.type.id)
     if _InstanceOfNode(database, parent_interface):
       return True
   return False