Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 10119007: [File Manager]Disable "Copy" command if selection contains dimmed GData files (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev
Modified:
8 years, 8 months ago
Reviewers:
SeRya
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[File Manager]Disable "Copy" command if selection contains dimmed GData files Abandoned in favor of https://chromiumcodereview.appspot.com/10184005/ BUG=chromium-os:29611 TEST=

Patch Set 1 #

Patch Set 2 : Removed debugging code #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -6 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 9 chunks +61 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_transfer_controller.js View 5 chunks +8 lines, -3 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
Please review
8 years, 8 months ago (2012-04-18 13:38:41 UTC) #1
dgozman
https://chromiumcodereview.appspot.com/10119007/diff/4/chrome/browser/resources/file_manager/js/file_transfer_controller.js File chrome/browser/resources/file_manager/js/file_transfer_controller.js (right): https://chromiumcodereview.appspot.com/10119007/diff/4/chrome/browser/resources/file_manager/js/file_transfer_controller.js#newcode386 chrome/browser/resources/file_manager/js/file_transfer_controller.js:386: this.selectionAvailable_ = available; I don't like this 'set from ...
8 years, 8 months ago (2012-04-18 16:07:37 UTC) #2
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/10119007/diff/4/chrome/browser/resources/file_manager/js/file_transfer_controller.js File chrome/browser/resources/file_manager/js/file_transfer_controller.js (right): https://chromiumcodereview.appspot.com/10119007/diff/4/chrome/browser/resources/file_manager/js/file_transfer_controller.js#newcode386 chrome/browser/resources/file_manager/js/file_transfer_controller.js:386: this.selectionAvailable_ = available; Yeah, I hate it myself. But ...
8 years, 8 months ago (2012-04-18 16:36:24 UTC) #3
Vladislav Kaznacheev
8 years, 8 months ago (2012-04-19 07:14:12 UTC) #4
Please review

Powered by Google App Engine
This is Rietveld 408576698