Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: webkit/extensions/v8/playback_extension.h

Issue 10117022: Cleanup of v8 extension stuff. Playback extension is only used in chrome, so move it to chrome\rend… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/extensions/v8/heap_profiler_extension.cc ('k') | webkit/extensions/v8/playback_extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/extensions/v8/playback_extension.h
===================================================================
--- webkit/extensions/v8/playback_extension.h (revision 132793)
+++ webkit/extensions/v8/playback_extension.h (working copy)
@@ -1,35 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef WEBKIT_EXTENSIONS_V8_PLAYBACK_EXTENSION_H_
-#define WEBKIT_EXTENSIONS_V8_PLAYBACK_EXTENSION_H_
-#pragma once
-
-#include "webkit/extensions/webkit_extensions_export.h"
-
-namespace v8 {
-class Extension;
-}
-
-namespace extensions_v8 {
-
-// Inject code which overrides a few common JS functions for implementing
-// randomness. In order to implement effective record & playback of
-// websites, it is important that the URLs not change. Many popular web
-// based apps use randomness in URLs to unique-ify urls for proxies.
-// Unfortunately, this breaks playback.
-// To work around this, we take the two most common client-side randomness
-// generators and make them constant. They really need to be constant
-// (rather than a constant seed followed by constant change)
-// because the playback mode wants flexibility in how it plays them back
-// and cannot always guarantee that requests for randomness are played back
-// in exactly the same order in which they were recorded.
-class PlaybackExtension {
- public:
- WEBKIT_EXTENSIONS_EXPORT static v8::Extension* Get();
-};
-
-} // namespace extensions_v8
-
-#endif // WEBKIT_EXTENSIONS_V8_PLAYBACK_EXTENSION_H_
« no previous file with comments | « webkit/extensions/v8/heap_profiler_extension.cc ('k') | webkit/extensions/v8/playback_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698