lib/compiler/implementation/ssa/tracer.dart - Issue 10116023: Don't rely on any speculative type in the bailout version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/tracer.dart

Issue 10116023: Don't rely on any speculative type in the bailout version. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Cosmetic change (formatting). Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/ssa/optimize.dart ('K') | « lib/compiler/implementation/ssa/optimize.dart ('k') | lib/compiler/implementation/ssa/types.dart » ('j') | lib/compiler/implementation/ssa/types.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/ssa/tracer.dart

diff --git a/lib/compiler/implementation/ssa/tracer.dart b/lib/compiler/implementation/ssa/tracer.dart

index dc91f69cec9fd54f5bfe0b70c7791790bc0373d6..7ee2e816bfe98a5cc5561d9727a3816ac808e687 100644

--- a/lib/compiler/implementation/ssa/tracer.dart

+++ b/lib/compiler/implementation/ssa/tracer.dart

@@ -403,7 +403,7 @@ class HInstructionStringifier implements HVisitor<String> {

String visitTypeGuard(HTypeGuard node) {

String type;

- switch (node.propagatedType) {

+ switch (node.guardedType) {

case HType.MUTABLE_ARRAY: type = "mutable_array"; break;

case HType.READABLE_ARRAY: type = "readable_array"; break;

case HType.BOOLEAN: type = "bool"; break;

@@ -415,7 +415,8 @@ class HInstructionStringifier implements HVisitor<String> {

case HType.UNKNOWN: type = 'unknown'; break;

default: unreachable();

}

- return "TypeGuard: ${temporaryId(node.inputs[0])} is $type";

+ String activeString = node.isActive ? "active" : "inactive";

+ return "TypeGuard: ${temporaryId(node.inputs[0])} is $type ($activeString)";

}

String visitIs(HIs node) {