Fix uber tray to accept focus via tab selection

chrome/browser/chromeos/login/webui_login_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/webui_login_view.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 302 matching lines @@
     if (web_ui)
       web_ui->CallJavascriptFunction("cr.ui.Oobe.clearErrors");
   }
 }
 
 bool WebUILoginView::IsPopupOrPanel(const WebContents* source) const {
   return true;
 }
 
 bool WebUILoginView::TakeFocus(bool reverse) {
+  ash::SystemTray* tray = ash::Shell::GetInstance()->tray();
+  if (tray) {
+    tray->TakeFocus(this);
+  }

[sadrul, 2012/04/19 16:12:35]

From a quick try, it looks like doing the following here works without changing
anything else:

+  ash::SystemTray* tray = ash::Shell::GetInstance()->tray();
+  tray->SetNextFocusableView(this);
+  ash::Shell::GetInstance()->RotateFocus(reverse ? ash::Shell::BACKWARD :
+                                                   ash::Shell::FORWARD);

Could you test and see if this actually works for all cases? If it does, then
this is probably a simpler fix.

[Zachary Kuznia, 2012/04/23 07:41:48]

Done.

   return true;
 }
 
 void WebUILoginView::ReturnFocus(bool reverse) {
   // Return the focus to the web contents.
   webui_login_->dom_contents()->web_contents()->
       FocusThroughTabTraversal(reverse);
   GetWidget()->Activate();
 }
 
 }  // namespace chromeos