src/trusted/validator_x86/ncenuminsts_x86_64.c - Issue 10116004: Eliminate bundle_size parameter from validator interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_x86/ncenuminsts_x86_64.c

Issue 10116004: Eliminate bundle_size parameter from validator interface. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Merge Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.c ('K') | « src/trusted/validator_x86/ncenuminsts_x86_32.c ('k') | src/trusted/validator_x86/ncval.c » ('j') | src/trusted/validator_x86/ncval_tests.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_x86/ncenuminsts_x86_64.c

diff --git a/src/trusted/validator_x86/ncenuminsts_x86_64.c b/src/trusted/validator_x86/ncenuminsts_x86_64.c

index 9d1b62e1d71b93c21c9c98e0c8549f5fc472ac29..ef9f06a0681cfee443a0e30bf16ddb19a1e99c0c 100644

--- a/src/trusted/validator_x86/ncenuminsts_x86_64.c

+++ b/src/trusted/validator_x86/ncenuminsts_x86_64.c

@@ -135,8 +135,8 @@ Bool NaClInstValidates(uint8_t* mbase,

NaClCPUFeaturesX86 cpu_features;

NaClGetCurrentCPUFeatures(&cpu_features);

- state = NaClValidatorStateCreate(vbase, (NaClMemorySize) size,

- 32, RegR15, FALSE, &cpu_features);

+ state = NaClValidatorStateCreate(vbase, (NaClMemorySize) size, RegR15, FALSE,

+ &cpu_features);

do {

NaClSegmentInitialize(mbase, vbase, (NaClMemorySize) size, &segment);

iter = NaClInstIterCreate(kNaClDecoderTables, &segment);

@@ -165,7 +165,7 @@ Bool NaClSegmentValidates(uint8_t* mbase,

/* check if NaCl thinks the given code segment is valid. */

NaClSetAllCPUFeatures(&cpu_features);

status = NaCl_ApplyValidator_x86_64(

- NACL_SB_DEFAULT, vbase, mbase, size, 32,

+ NACL_SB_DEFAULT, vbase, mbase, size,

/* stubout_mode= */ FALSE, /* readonly_text= */ FALSE, &cpu_features,

NULL);

switch (status) {